Ticket #127 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

CodeSniffer handles // @codeCoverageIgnoreStart wrong

Reported by: mikey Assigned to: rist
Priority: major Milestone:
Component: Build System Version: SVN-trunk
Keywords: Cc:

Description (Last modified by mikey)

Methods marked with // @codeCoverageIgnoreStart are handled wrong by our codesniffer sniffs. These lines should be ignored. See net::stubbles::ioc::stubBindingScopes for an example.

Change History

02/25/08 17:39:55 changed by mikey

  • description changed.

02/26/08 14:45:52 changed by rist

  • status changed from new to closed.
  • resolution set to fixed.

fixed with changeset:1375

02/26/08 18:24:38 changed by mikey

  • status changed from closed to reopened.
  • resolution deleted.

Unfortunately the fix introduces some other error (or brings another error to light which was simply not shown before the fix). The code sniffer now complains about missing doc comments on methods if methods are marked with the coverage comments:

/**
 * returns the raw data
 *
 * @return  string
 */
// @codeCoverageIgnoreStart
protected function getRawData()
{
    return file_get_contents('php://input');
}
// @codeCoverageIgnoreEnd
[exec] FILE: ...s\php\stubbles\src\main\php\net\stubbles\ipo\request\stubWebRequest.php
[exec] --------------------------------------------------------------------------------
[exec] FOUND 1 ERROR(S) AND 0 WARNING(S) AFFECTING 1 LINE(S)
[exec] --------------------------------------------------------------------------------
[exec]  87 | ERROR | Missing @return tag in function comment
[exec] --------------------------------------------------------------------------------

02/27/08 15:07:46 changed by rist

  • status changed from reopened to closed.
  • resolution set to fixed.

should be fixed now (changeset:1384).