Changeset 524

Show
Ignore:
Timestamp:
04/14/07 18:48:26 (1 year ago)
Author:
mikey
Message:

do not add name of root variant to full qualified variant name

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/docroot/variants.php

    r447 r524  
    1414        $request = new stubWebRequest(); 
    1515        $session = new stubPHPSession($request, 'web'); 
    16         var_dump($factory->getVariantsMap()->getVariant($session, $request)->getName()); 
     16        var_dump($factory->getVariantsMap()->getVariant($session, $request)->getFullQualifiedName()); 
    1717    } 
    1818} 
  • trunk/src/main/php/net/stubbles/websites/variantmanager/types/stubAbstractVariant.php

    r523 r524  
    8181    public function getFullQualifiedName() 
    8282    { 
    83         if ($this->hasParent() == true) { 
     83        if ($this->hasParent() == true && ($this->parent instanceof stubRootVariant) == false) { 
    8484            return $this->parent->getFullQualifiedName() . ':' . $this->name; 
    8585        } 
  • trunk/src/test/php/net/stubbles/websites/variantmanager/types/stubAbstractVariantTestCase.php

    r523 r524  
    224224        $this->assertEqual($this->abstractVariant->getFullQualifiedName(), 'foo:bar'); 
    225225    } 
     226     
     227    /** 
     228     * test full qualified name when parent variant is root variant 
     229     */ 
     230    public function testParentRoot() 
     231    { 
     232        $this->abstractVariant->setName('bar'); 
     233        $rootVariant = new stubRootVariant(); 
     234        $this->abstractVariant->setParent($rootVariant); 
     235        $this->assertEqual($this->abstractVariant->getFullQualifiedName(), 'bar'); 
     236    } 
    226237} 
    227238?>