Changeset 339

Timestamp:

03/06/07 16:32:01 (2 years ago)

Author:

mikey

Message:

add a RequestValueError? with the same id only once to the same value

Files:

• trunk/docroot/xml.php (modified) (1 diff)
• trunk/src/main/php/net/stubbles/ipo/request/stubAbstractRequest.php (modified) (1 diff)
• trunk/src/test/php/net/stubbles/ipo/request/stubAbstractRequestTestCase.php (modified) (2 diffs)

trunk/docroot/xml.php

@@ -45 +45 @@
-        }
-        $request->getFilteredValue(new TestFilter(), 'foo_bar');
+        $request->getFilteredValue(new TestFilter(), 'foo_bar');
-        $pageFactory = new stubXJConfPageFactory(stubXJConfLoader::getInstance());
-        $processor   = new stubXMLProcessor($request, $session, $response, $pageFactory);

trunk/src/main/php/net/stubbles/ipo/request/stubAbstractRequest.php

@@ -267 +267 @@
-            $error =& $this->getErrors($source);
-            if (isset($error[$valueName]) == false) {
-
+
+
+
+
+
+
+
+
+
+
-            }
-            
-            $error[$valueName][] = $fe->getError();
-            return null;
-        }

trunk/src/test/php/net/stubbles/ipo/request/stubAbstractRequestTestCase.php

@@ -7 +7 @@
- * @subpackage  ipo_test
- */
-
+
+
+
-Mock::generate('stubValidator');
-Mock::generate('stubFilter');
-Mock::generate('stubEventListener');
+class stubTestExceptionFilter extends stubAbstractFilter
+{
+    public function execute($value)
+    {
+        throw new stubFilterException(new stubRequestValueError('foo', array()));
+    }
+}
-class stubTestRequest extends stubAbstractRequest
-{
@@ -294 +303 @@
-        $this->assertEqual($this->request->getValueErrors(stubRequest::SOURCE_COOKIE), array('foo' => array($errorValue)));
-    }
+    
+    /**
+     * assure that the same error occurs only once in list of errors for a value
+     */
+   public function testErrorOnlyAddedOnce()
+    {
+        $errorValue = new stubRequestValueError('foo', array());
+        $this->request->setValueError('foo', $errorValue);
+        $this->assertEqual($this->request->getValueError('foo'), array($errorValue));
+        $this->request->getFilteredValue(new stubTestExceptionFilter(), 'foo');
+        $this->assertEqual($this->request->getValueError('foo'), array($errorValue));
+    }
-}
-?>