Changeset 1464

Show
Ignore:
Timestamp:
03/26/08 23:28:58 (4 months ago)
Author:
mikey
Message:

cover wrong configuration cases

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/src/main/php/net/stubbles/websites/stubFrontController.php

    r1459 r1464  
    7979        $fqClassName = stubRegistry::getConfig(stubRequest::CLASS_REGISTRY_KEY, 'net::stubbles::ipo::request::stubWebRequest'); 
    8080        $className   = stubClassLoader::getNonQualifiedClassName($fqClassName); 
    81         if (class_exists($className, false) == false) { 
     81        if (class_exists($className, false) === false) { 
    8282            stubClassLoader::load($fqClassName); 
    8383        } 
    8484         
    8585        $this->request = new $className(); 
    86         if (($this->request instanceof stubRequest) == false) { 
     86        if (($this->request instanceof stubRequest) === false) { 
    8787            throw new stubRuntimeException('Configured request class is not an instance of net::stubbles::ipo::request::stubRequest.'); 
    8888        } 
     
    9090        $fqClassName = stubRegistry::getConfig(stubSession::CLASS_REGISTRY_KEY, 'net::stubbles::ipo::session::stubPHPSession'); 
    9191        $className   = stubClassLoader::getNonQualifiedClassName($fqClassName); 
    92         if (class_exists($className, false) == false) { 
     92        if (class_exists($className, false) === false) { 
    9393            stubClassLoader::load($fqClassName); 
    9494        } 
    9595         
    9696        $this->session = new $className($this->request, stubRegistry::getConfig(stubSession::NAME_REGISTRY_KEY, stubSession::DEFAULT_SESSION_NAME)); 
    97         if (($this->session instanceof stubSession) == false) { 
     97        if (($this->session instanceof stubSession) === false) { 
    9898            throw new stubRuntimeException('Configured session class is not an instance of net::stubbles::ipo::session::stubSession.'); 
    9999        } 
  • trunk/src/test/php/net/stubbles/websites/stubFrontControllerTestCase.php

    r1459 r1464  
    116116        $mockWebsiteInitializer       = $this->getMock('stubWebsiteInitializer'); 
    117117        $mockProcessorResolverFactory = $this->getMock('stubProcessorResolverFactory'); 
    118         $mockWebsiteInitializer->expects($this->once())->method('getProcessorResolverFactory')->will($this->returnValue($mockProcessorResolverFactory)); 
     118        $mockWebsiteInitializer->expects($this->any())->method('getProcessorResolverFactory')->will($this->returnValue($mockProcessorResolverFactory)); 
    119119        $this->mockProcessorResolver  = $this->getMock('stubProcessorResolver'); 
    120120        $this->mockProcessor          = $this->getMock('stubProcessor'); 
    121         $mockProcessorResolverFactory->expects($this->once()) 
     121        $mockProcessorResolverFactory->expects($this->any()) 
    122122                                     ->method('getResolver') 
    123123                                     ->will($this->returnValue($this->mockProcessorResolver)); 
    124         $this->mockProcessorResolver->expects($this->once()) 
     124        $this->mockProcessorResolver->expects($this->any()) 
    125125                                    ->method('resolve') 
    126126                                    ->will($this->returnValue($this->mockProcessor)); 
     
    129129        stubRegistry::setConfig(stubRequest::CLASS_REGISTRY_KEY, get_class($this->getMock('stubRequest'))); 
    130130        stubRegistry::setConfig(stubSession::CLASS_REGISTRY_KEY, get_class($this->getMock('stubSession'))); 
    131         $mockWebsiteInitializer->expects($this->once())->method('getRegistryInitializer')->will($this->returnValue($this->getMock('stubRegistryInitializer'))); 
    132         $mockWebsiteInitializer->expects($this->once())->method('hasGeneralInitializer')->will($this->returnValue(true)); 
     131        $mockWebsiteInitializer->expects($this->any())->method('getRegistryInitializer')->will($this->returnValue($this->getMock('stubRegistryInitializer'))); 
     132        $mockWebsiteInitializer->expects($this->any())->method('hasGeneralInitializer')->will($this->returnValue(true)); 
    133133        $generalInitializer = $this->getMock('stubInitializer'); 
    134         $generalInitializer->expects($this->once())->method('init'); 
    135         $mockWebsiteInitializer->expects($this->once())->method('getGeneralInitializer')->will($this->returnValue($generalInitializer)); 
     134        $generalInitializer->expects($this->any())->method('init'); 
     135        $mockWebsiteInitializer->expects($this->any())->method('getGeneralInitializer')->will($this->returnValue($generalInitializer)); 
    136136        $this->frontController = new TeststubFrontController($mockWebsiteInitializer); 
    137137         
     
    300300        $this->frontController->process(); 
    301301    } 
     302 
     303    /** 
     304     * wrong session class throws an exception 
     305     * 
     306     * @test 
     307     * @expectedException  stubRuntimeException 
     308     */ 
     309    public function wrongRequestClass() 
     310    { 
     311        stubRegistry::setConfig(stubRequest::CLASS_REGISTRY_KEY, 'stdClass'); 
     312        $mockWebsiteInitializer = $this->getMock('stubWebsiteInitializer'); 
     313        $mockWebsiteInitializer->expects($this->once())->method('getRegistryInitializer')->will($this->returnValue($this->getMock('stubRegistryInitializer'))); 
     314        $mockWebsiteInitializer->expects($this->once())->method('hasGeneralInitializer')->will($this->returnValue(false)); 
     315        $frontController = new stubFrontController($mockWebsiteInitializer); 
     316    } 
     317    /** 
     318     * wrong session class throws an exception 
     319     * 
     320     * @test 
     321     * @expectedException  stubRuntimeException 
     322     */ 
     323    public function wrongSessionClass() 
     324    { 
     325        stubRegistry::setConfig(stubRequest::CLASS_REGISTRY_KEY, get_class($this->getMock('stubRequest'))); 
     326        stubRegistry::setConfig(stubSession::CLASS_REGISTRY_KEY, 'stdClass'); 
     327        $mockWebsiteInitializer = $this->getMock('stubWebsiteInitializer'); 
     328        $mockWebsiteInitializer->expects($this->once())->method('getRegistryInitializer')->will($this->returnValue($this->getMock('stubRegistryInitializer'))); 
     329        $mockWebsiteInitializer->expects($this->once())->method('hasGeneralInitializer')->will($this->returnValue(false)); 
     330        $frontController = new stubFrontController($mockWebsiteInitializer); 
     331    } 
    302332} 
    303333?>