Changeset 1455

Timestamp:

03/23/08 01:38:17 (6 months ago)

Author:

mikey

Message:

ignore one method and test cookie creation

Files:

• trunk/src/main/php/net/stubbles/websites/variantmanager/stubVariantsPreInterceptor.php (modified) (3 diffs)
• trunk/src/test/php/net/stubbles/websites/variantmanager/stubVariantsPreInterceptorCookieVariantTestCase.php (modified) (2 diffs)

trunk/src/main/php/net/stubbles/websites/variantmanager/stubVariantsPreInterceptor.php

@@ -77 +77 @@
-        }
-        
-
+=
-            $variant = $variantFactory->getVariantsMap()->getVariant($session, $request);
-        }
@@ -95 +95 @@
-     * @return  stubVariantFactory
-     */
+    // @codeCoverageIgnoreStart
-    protected function createVariantFactory($classname)
-    {
-        return new $classname();
-    }
+    // @codeCoverageIgnoreEnd
-    
-    /**
@@ -122 +124 @@
-        $cookieVariant    = $variantFactory->getVariantByName($variantName);
-        $enforcingVariant = $variantFactory->getVariantsMap()->getEnforcingVariant($session, $request);
-
+=
-            return $cookieVariant;
-        }

trunk/src/test/php/net/stubbles/websites/variantmanager/stubVariantsPreInterceptorCookieVariantTestCase.php

@@ -12 +12 @@
-                      'net::stubbles::websites::variantmanager::types::stubVariant'
-);
+/**
+ * Helper class for the test.
+ *
+ * @package     stubbles
+ * @subpackage  websites_variantmanager_test
+ */
-class TestVariantsPreInterceptor extends stubVariantsPreInterceptor
-{
+    /**
+     * returns the cookie variant
+     *
+     * @param   stubRequest         $request
+     * @param   stubSession         $session
+     * @param   stubVariantFactory  $variantFactory
+     * @param   string              $cookieName
+     * @return  stubVariant
+     */
-    public function getCookieVariant(stubRequest $request, stubSession $session, stubVariantFactory $variantFactory, $cookieName)
-    {
-        return $this->getVariantFromCookie($request, $session, $variantFactory, $cookieName);
+    }
+
+    /**
+     * returns the created cookie
+     *
+     * @param   string      $cookieName
+     * @param   string      $variantName
+     * @param   int         $expiring
+     * @param   string      $cookieURL
+     * @param   string      $cookiePath
+     * @return  stubCookie
+     */
+    public function callCreateCookie($cookieName, $variantName, $expiring, $cookieURL, $cookiePath)
+    {
+        return $this->createCookie($cookieName, $variantName, $expiring, $cookieURL, $cookiePath);
-    }
-}
@@ -154 +184 @@
-        $this->assertSame($barVariant, $resultVariant);
-    }
+
+    /**
+     * make sure cookie is created correct
+     *
+     * @test
+     */
+    public function createCookie()
+    {
+        $cookie = $this->variantPreInterceptor->callCreateCookie('name', 'value', 3600, 'url', 'path');
+        $this->assertEquals('name', $cookie->getName());
+        $this->assertEquals('value', $cookie->getValue());
+        $this->assertGreaterThan(time() + 3550, $cookie->getExpiration());
+        $this->assertEquals('url', $cookie->getDomain());
+        $this->assertEquals('path', $cookie->getPath());
+    }
-}
-?>