Changeset 1423
- Timestamp:
- 03/14/08 16:09:18 (6 months ago)
- Files:
-
- trunk/src/main/php/net/stubbles/websites/xml/generator/stubPageXMLGenerator.php (moved) (moved from trunk/src/main/php/net/stubbles/websites/xml/generator/stubPageXMLElement.php) (3 diffs)
- trunk/src/main/php/net/stubbles/websites/xml/generator/stubRequestXMLGenerator.php (moved) (moved from trunk/src/main/php/net/stubbles/websites/xml/generator/stubRequestXMLElement.php) (3 diffs)
- trunk/src/main/php/net/stubbles/websites/xml/generator/stubSessionXMLGenerator.php (moved) (moved from trunk/src/main/php/net/stubbles/websites/xml/generator/stubSessionXMLElement.php) (3 diffs)
- trunk/src/main/php/net/stubbles/websites/xml/generator/stubXMLGenerator.php (moved) (moved from trunk/src/main/php/net/stubbles/websites/xml/generator/stubGlobalXMLElement.php) (3 diffs)
- trunk/src/main/php/net/stubbles/websites/xml/stubXMLProcessor.php (modified) (3 diffs)
- trunk/src/test/php/net/stubbles/websites/WebsitesTestSuite.php (modified) (1 diff)
- trunk/src/test/php/net/stubbles/websites/xml/generator/stubPageXMLGeneratorTestCase.php (moved) (moved from trunk/src/test/php/net/stubbles/websites/xml/generator/stubPageXMLElementTestCase.php) (7 diffs)
- trunk/src/test/php/net/stubbles/websites/xml/generator/stubRequestXMLGeneratorTestCase.php (moved) (moved from trunk/src/test/php/net/stubbles/websites/xml/generator/stubRequestXMLElementTestCase.php) (5 diffs)
- trunk/src/test/php/net/stubbles/websites/xml/generator/stubSessionXMLGeneratorTestCase.php (moved) (moved from trunk/src/test/php/net/stubbles/websites/xml/generator/stubSessionXMLElementTestCase.php) (5 diffs)
- trunk/src/test/php/net/stubbles/websites/xml/stubXMLProcessorTestCase.php (modified) (4 diffs)
Legend:
- Unmodified
- Added
- Removed
- Modified
- Copied
- Moved
trunk/src/main/php/net/stubbles/websites/xml/generator/stubPageXMLGenerator.php
r1422 r1423 14 14 'net::stubbles::util::stubRegistry', 15 15 'net::stubbles::websites::stubPage', 16 'net::stubbles::websites::xml::generator::stub GlobalXMLElement'16 'net::stubbles::websites::xml::generator::stubXMLGenerator' 17 17 ); 18 18 /** … … 22 22 * @subpackage websites_xml_generator 23 23 */ 24 class stubPageXML Element extends stubBaseObject implements stubGlobalXMLElement24 class stubPageXMLGenerator extends stubBaseObject implements stubXMLGenerator 25 25 { 26 26 /** … … 80 80 * @param stubXMLSerializer $xmlSerializer serializer to be used 81 81 */ 82 public function append(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer)82 public function generate(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer) 83 83 { 84 84 $prefixRequest = new stubRequestPrefixDecorator($this->request, ''); trunk/src/main/php/net/stubbles/websites/xml/generator/stubRequestXMLGenerator.php
r1422 r1423 8 8 */ 9 9 stubClassLoader::load('net::stubbles::ipo::request::stubRequest', 10 'net::stubbles::websites::xml::generator::stub GlobalXMLElement'10 'net::stubbles::websites::xml::generator::stubXMLGenerator' 11 11 ); 12 12 /** … … 37 37 * @subpackage websites_xml_generator 38 38 */ 39 class stubRequestXML Element extends stubBaseObject implements stubGlobalXMLElement39 class stubRequestXMLGenerator extends stubBaseObject implements stubXMLGenerator 40 40 { 41 41 /** … … 63 63 * @param stubXMLSerializer $xmlSerializer serializer to be used 64 64 */ 65 public function append(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer)65 public function generate(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer) 66 66 { 67 67 $xmlStreamWriter->writeStartElement('request'); trunk/src/main/php/net/stubbles/websites/xml/generator/stubSessionXMLGenerator.php
r1422 r1423 10 10 'net::stubbles::ipo::session::stubSession', 11 11 'net::stubbles::util::stubRegistry', 12 'net::stubbles::websites::xml::generator::stub GlobalXMLElement'12 'net::stubbles::websites::xml::generator::stubXMLGenerator' 13 13 ); 14 14 /** … … 42 42 * @subpackage websites_xml_generator 43 43 */ 44 class stubSessionXML Element extends stubBaseObject implements stubGlobalXMLElement44 class stubSessionXMLGenerator extends stubBaseObject implements stubXMLGenerator 45 45 { 46 46 /** … … 76 76 * @param stubXMLSerializer $xmlSerializer serializer to be used 77 77 */ 78 public function append(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer)78 public function generate(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer) 79 79 { 80 80 $xmlStreamWriter->writeStartElement('session'); trunk/src/main/php/net/stubbles/websites/xml/generator/stubXMLGenerator.php
r1422 r1423 1 1 <?php 2 2 /** 3 * Interface for g lobal xml elements available on all pages of the xml result document.3 * Interface for generators of the xml result document. 4 4 * 5 5 * @author Frank Kleine <mikey@stubbles.net> … … 11 11 ); 12 12 /** 13 * Interface for g lobal xml elements available on all pages of the xml result document.13 * Interface for generators of the xml result document. 14 14 * 15 15 * @package stubbles 16 16 * @subpackage websites_xml_generator 17 17 */ 18 interface stub GlobalXMLElementextends stubObject18 interface stubXMLGenerator extends stubObject 19 19 { 20 20 /** … … 24 24 * @param stubXMLSerializer $xmlSerializer serializer to be used 25 25 */ 26 public function append(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer);26 public function generate(stubXMLStreamWriter $xmlStreamWriter, stubXMLSerializer $xmlSerializer); 27 27 } 28 28 ?> trunk/src/main/php/net/stubbles/websites/xml/stubXMLProcessor.php
r1422 r1423 26 26 { 27 27 /** 28 * list of global elements to be serialized into result xml28 * list of xml generators to be used to create the dom tree 29 29 * 30 30 * @var array<string> 31 31 */ 32 protected $ globalElements = array();32 protected $xmlGenerators = array(); 33 33 34 34 /** … … 45 45 parent::__construct($request, $session, $response, $pageFactory); 46 46 $this->pageDirPrefix = 'conf/'; 47 $this->configure GlobalElements();47 $this->configureXMLGenerators(); 48 48 } 49 49 50 50 /** 51 * configure d the global elements51 * configure the xml generators 52 52 */ 53 protected function configure GlobalElements()53 protected function configureXMLGenerators() 54 54 { 55 $this-> globalElements = array('net::stubbles::websites::xml::generator::stubSessionXMLElement',56 'net::stubbles::websites::xml::generator::stubPageXMLElement',57 'net::stubbles::websites::xml::generator::stubRequestXMLElement'58 );55 $this->xmlGenerators = array('net::stubbles::websites::xml::generator::stubSessionXMLGenerator', 56 'net::stubbles::websites::xml::generator::stubPageXMLGenerator', 57 'net::stubbles::websites::xml::generator::stubRequestXMLGenerator' 58 ); 59 59 } 60 60 … … 80 80 $xmlStreamWriter->writeAttribute('page', $pageName); 81 81 $xmlSerializer = $this->createXMLSerializer(); 82 foreach ($this-> globalElements as $globalElementClassName) {83 $ globalElement = $injector->getInstance($globalElementClassName);84 $ globalElement->append($xmlStreamWriter, $xmlSerializer);82 foreach ($this->xmlGenerators as $xmlGeneratorClassName) { 83 $xmlGenerator = $injector->getInstance($xmlGeneratorClassName); 84 $xmlGenerator->generate($xmlStreamWriter, $xmlSerializer); 85 85 } 86 86 trunk/src/test/php/net/stubbles/websites/WebsitesTestSuite.php
r1422 r1423 54 54 55 55 // xml generators 56 $suite->addTestFile($dir . '/xml/generator/stubPageXML ElementTestCase.php');57 $suite->addTestFile($dir . '/xml/generator/stubRequestXML ElementTestCase.php');58 $suite->addTestFile($dir . '/xml/generator/stubSessionXML ElementTestCase.php');56 $suite->addTestFile($dir . '/xml/generator/stubPageXMLGeneratorTestCase.php'); 57 $suite->addTestFile($dir . '/xml/generator/stubRequestXMLGeneratorTestCase.php'); 58 $suite->addTestFile($dir . '/xml/generator/stubSessionXMLGeneratorTestCase.php'); 59 59 return $suite; 60 60 } trunk/src/test/php/net/stubbles/websites/xml/generator/stubPageXMLGeneratorTestCase.php
r1422 r1423 1 1 <?php 2 2 /** 3 * Tests for net::stubbles::websites::xml::g lobal::stubPageXMLElement.3 * Tests for net::stubbles::websites::xml::generator::stubPageXMLGenerator. 4 4 * 5 5 * @author Frank Kleine <mikey@stubbles.net> … … 7 7 * @subpackage websites_xml_generator_test 8 8 */ 9 stubClassLoader::load('net::stubbles::websites::xml::generator::stubPageXML Element');9 stubClassLoader::load('net::stubbles::websites::xml::generator::stubPageXMLGenerator'); 10 10 /** 11 * Tests for net::stubbles::websites::xml::g lobal::stubPageXMLElement.11 * Tests for net::stubbles::websites::xml::generator::stubPageXMLGenerator. 12 12 * 13 13 * @package stubbles 14 14 * @subpackage websites_xml_generator_test 15 15 */ 16 class stubPageXML ElementTestCase extends PHPUnit_Framework_TestCase16 class stubPageXMLGeneratorTestCase extends PHPUnit_Framework_TestCase 17 17 { 18 18 /** 19 19 * instance to test 20 20 * 21 * @var stubPageXML Element21 * @var stubPageXMLGenerator 22 22 */ 23 protected $pageXML Element;23 protected $pageXMLGenerator; 24 24 /** 25 25 * mocked request instance … … 75 75 $this->page = new stubPage(); 76 76 $this->mockInjector = $this->getMock('stubInjector'); 77 $this->pageXML Element = new stubPageXMLElement($this->mockRequest, $this->mockSession, $this->mockResponse, $this->page, $this->mockInjector);77 $this->pageXMLGenerator = new stubPageXMLGenerator($this->mockRequest, $this->mockSession, $this->mockResponse, $this->page, $this->mockInjector); 78 78 $this->mockXMLStreamWriter = $this->getMock('stubXMLStreamWriter'); 79 79 $this->mockXMLSerializer = $this->getMock('stubXMLSerializer'); … … 102 102 $this->mockXMLStreamWriter->expects($this->once())->method('writeStartElement'); 103 103 $this->mockXMLStreamWriter->expects($this->once())->method('writeEndElement'); 104 $this->pageXML Element->append($this->mockXMLStreamWriter, $this->mockXMLSerializer);104 $this->pageXMLGenerator->generate($this->mockXMLStreamWriter, $this->mockXMLSerializer); 105 105 } 106 106 … … 141 141 $this->mockXMLStreamWriter->expects($this->once())->method('writeStartElement'); 142 142 $this->mockXMLStreamWriter->expects($this->once())->method('writeEndElement'); 143 $this->pageXML Element->append($this->mockXMLStreamWriter, $this->mockXMLSerializer);143 $this->pageXMLGenerator->generate($this->mockXMLStreamWriter, $this->mockXMLSerializer); 144 144 } 145 145 … … 167 167 $this->mockXMLStreamWriter->expects($this->never())->method('writeStartElement'); 168 168 $this->mockXMLStreamWriter->expects($this->never())->method('writeEndElement'); 169 $this->pageXML Element->append($this->mockXMLStreamWriter, $this->mockXMLSerializer);169 $this->pageXMLGenerator->generate($this->mockXMLStreamWriter, $this->mockXMLSerializer); 170 170 } 171 171 … … 191 191 $this->mockXMLStreamWriter->expects($this->once())->method('writeStartElement'); 192 192 $this->mockXMLStreamWriter->expects($this->once())->method('writeEndElement'); 193 $this->pageXML Element->append($this->mockXMLStreamWriter, $this->mockXMLSerializer);193 $this->pageXMLGenerator->generate($this->mockXMLStreamWriter, $this->mockXMLSerializer); 194 194 195 195 } trunk/src/test/php/net/stubbles/websites/xml/generator/stubRequestXMLGeneratorTestCase.php
r1422 r1423 1 1 <?php 2 2 /** 3 * Tests for net::stubbles::websites::xml::g lobal::stubRequestXMLElement.3 * Tests for net::stubbles::websites::xml::generator::stubRequestXMLGenerator. 4 4 * 5 5 * @author Frank Kleine <mikey@stubbles.net> … … 7 7 * @subpackage websites_xml_generator_test 8 8 */ 9 stubClassLoader::load('net::stubbles::websites::xml::generator::stubRequestXML Element');9 stubClassLoader::load('net::stubbles::websites::xml::generator::stubRequestXMLGenerator'); 10 10 /** 11 * Tests for net::stubbles::websites::xml::g lobal::stubRequestXMLElement.11 * Tests for net::stubbles::websites::xml::generator::stubRequestXMLGenerator. 12 12 * 13 13 * @package stubbles 14 14 * @subpackage websites_xml_generator_test 15 15 */ 16 class stubRequestXML ElementTestCase extends PHPUnit_Framework_TestCase16 class stubRequestXMLGeneratorTestCase extends PHPUnit_Framework_TestCase 17 17 { 18 18 /** 19 19 * instance to test 20 20 * 21 * @var stubRequestXML Element21 * @var stubRequestXMLGenerator 22 22 */ 23 protected $requestXML Element;23 protected $requestXMLGenerator; 24 24 /** 25 25 * mocked request instance … … 47 47 { 48 48 $this->mockRequest = $this->getMock('stubRequest'); 49 $this->requestXML Element = new stubRequestXMLElement($this->mockRequest);49 $this->requestXMLGenerator = new stubRequestXMLGenerator($this->mockRequest); 50 50 $this->mockXMLStreamWriter = $this->getMock('stubXMLStreamWriter'); 51 51 $this->mockXMLSerializer = $this->getMock('stubXMLSerializer'); … … 63 63 $this->mockRequest->expects($this->once())->method('getValueErrors')->will($this->returnValue(array())); 64 64 $this->mockXMLSerializer->expects($this->never())->method('serialize'); 65 $this->requestXML Element->append($this->mockXMLStreamWriter, $this->mockXMLSerializer);65 $this->requestXMLGenerator->generate($this->mockXMLStreamWriter, $this->mockXMLSerializer); 66 66 } 67 67 … … 80 80 $this->mockRequest->expects($this->once())->method('getValueErrors')->will($this->returnValue(array('foo' => array($error)))); 81 81 $this->mockXMLSerializer->expects($this->once())->method('serialize')->with($this->equalTo(array($error)), $this->equalTo($this->mockXMLStreamWriter)); 82 $this->requestXML Element->append($this->mockXMLStreamWriter, $this->mockXMLSerializer);82 $this->requestXMLGenerator->generate($this->mockXMLStreamWriter, $this->mockXMLSerializer); 83 83 } 84 84 } trunk/src/test/php/net/stubbles/websites/xml/generator/stubSessionXMLGeneratorTestCase.php
r1422 r1423 1 1 <?php 2 2 /** 3 * Tests for net::stubbles::websites::xml::g lobal::stubSessionXMLElement.3 * Tests for net::stubbles::websites::xml::generator::stubSessionXMLGenerator. 4 4 * 5 5 * @author Frank Kleine <mikey@stubbles.net> … … 7 7 * @subpackage websites_xml_generator_test 8 8 */ 9 stubClassLoader::load('net::stubbles::websites::xml::generator::stubSessionXML Element',9 stubClassLoader::load('net::stubbles::websites::xml::generator::stubSessionXMLGenerator', 10 10 'net::stubbles::xml::stubXMLStreamWriterFactory' 11 11 ); 12 12 /** 13 * Tests for net::stubbles::websites::xml::g lobal::stubSessionXMLElement.13 * Tests for net::stubbles::websites::xml::generator::stubSessionXMLGenerator. 14 14 * 15 15 * @package stubbles 16 16 * @subpackage websites_xml_generator_test 17 17 */ 18 class stubSessionXML ElementTestCase extends PHPUnit_Framework_TestCase18 class stubSessionXMLGeneratorTestCase extends PHPUnit_Framework_TestCase 19 19 { 20 20 /** 21 21 * instance to test 22 22 * 23 * @var stubSessionXML Element23 * @var stubSessionXMLGenerator 24 24 */ 25 protected $requestXML Element;25 protected $requestXMLGenerator; 26 26 /** 27 27 * mocked request instance … … 56 56 $this->mockRequest = $this->getMock('stubRequest'); 57 57 $this->mockSession = $this->getMock('stubSession'); 58 $this->requestXML Element = new stubSessionXMLElement($this->mockRequest, $this->mockSession);58 $this->requestXMLGenerator = new stubSessionXMLGenerator($this->mockRequest, $this->mockSession); 59 59 $this->xmlStreamWriter = stubXMLStreamWriterFactory::createAsAvailable(); 60 60 $this->mockXMLSerializer = $this->getMock('stubXMLSerializer'); … … 75 75 $this->mockSession->expects($this->once())->method('getCurrentToken')->will($this->returnValue('bar')); 76 76 $this->mockSession->expects($this->once())->method('getNextToken')->will($this->returnValue('baz')); 77 $this->requestXML Element->append($this->xmlStreamWriter, $this->mockXMLSerializer);77 $this->requestXMLGenerator->generate($this->xmlStreamWriter, $this->mockXMLSerializer); 78 78 $doc = $this->xmlStreamWriter->asXML(); 79 79 $this->assertEquals('<?xml version="1.0" encoding="UTF-8"?>' . "\n" . … … 108 108 $this->mockSession->expects($this->once())->method('getCurrentToken')->will($this->returnValue('bar')); 109 109 $this->mockSession->expects($this->once())->method('getNextToken')->will($this->returnValue('baz')); 110 $this->requestXML Element->append($this->xmlStreamWriter, $this->mockXMLSerializer);110 $this->requestXMLGenerator->generate($this->xmlStreamWriter, $this->mockXMLSerializer); 111 111 $doc = $this->xmlStreamWriter->asXML(); 112 112 $this->assertEquals('<?xml version="1.0" encoding="UTF-8"?>' . "\n" . trunk/src/test/php/net/stubbles/websites/xml/stubXMLProcessorTestCase.php
r1419 r1423 7 7 * @subpackage websites_xml_test 8 8 */ 9 stubClassLoader::load('net::stubbles::websites::xml::stubXMLProcessor'); 9 stubClassLoader::load('net::stubbles::websites::xml::stubXMLProcessor', 10 'net::stubbles::websites::xml::generator::stubXMLGenerator' 11 ); 10 12 /** 11 13 * Tests for net::stubbles::websites::xml::stubXMLProcessor. … … 137 139 $this->mockXMLStreamWriter->expects($this->once())->method('writeAttribute')->with($this->equalTo('page'), $this->equalTo('index')); 138 140 $this->mockXMLStreamWriter->expects($this->once())->method('writeEndElement'); 139 $mock GlobalXMLElement = $this->getMock('stubGlobalXMLElement');140 $this->mockInjector->expects($this->exactly(3))->method('getInstance')->will($this->returnValue($mock GlobalXMLElement));141 $mock GlobalXMLElement->expects($this->exactly(3))->method('append')->with($this->equalTo($this->mockXMLStreamWriter), $this->equalTo($this->mockXMLSerializer));141 $mockXMLGenerator = $this->getMock('stubXMLGenerator'); 142 $this->mockInjector->expects($this->exactly(3))->method('getInstance')->will($this->returnValue($mockXMLGenerator)); 143 $mockXMLGenerator->expects($this->exactly(3))->method('generate')->with($this->equalTo($this->mockXMLStreamWriter), $this->equalTo($this->mockXMLSerializer)); 142 144 $resultXSL = new DOMDocument(); 143 145 $mockSkinGenerator = $this->getMock('stubSkinGenerator'); … … 174 176 $this->mockXMLStreamWriter->expects($this->once())->method('writeAttribute')->with($this->equalTo('page'), $this->equalTo('index')); 175 177 $this->mockXMLStreamWriter->expects($this->once())->method('writeEndElement'); 176 $mock GlobalXMLElement = $this->getMock('stubGlobalXMLElement');177 $this->mockInjector->expects($this->exactly(3))->method('getInstance')->will($this->returnValue($mock GlobalXMLElement));178 $mock GlobalXMLElement->expects($this->exactly(3))->method('append')->with($this->equalTo($this->mockXMLStreamWriter), $this->equalTo($this->mockXMLSerializer));178 $mockXMLGenerator = $this->getMock('stubXMLGenerator'); 179 $this->mockInjector->expects($this->exactly(3))->method('getInstance')->will($this->returnValue($mockXMLGenerator)); 180 $mockXMLGenerator->expects($this->exactly(3))->method('generate')->with($this->equalTo($this->mockXMLStreamWriter), $this->equalTo($this->mockXMLSerializer)); 179 181 $resultXSL = new DOMDocument(); 180 182 $mockSkinGenerator = $this->getMock('stubSkinGenerator'); … … 212 214 $this->mockXMLStreamWriter->expects($this->once())->method('writeAttribute')->with($this->equalTo('page'), $this->equalTo('baz')); 213 215 $this->mockXMLStreamWriter->expects($this->once())->method('writeEndElement'); 214 $mock GlobalXMLElement = $this->getMock('stubGlobalXMLElement');215 $this->mockInjector->expects($this->exactly(3))->method('getInstance')->will($this->returnValue($mock GlobalXMLElement));216 $mock GlobalXMLElement->expects($this->exactly(3))->method('append')->with($this->equalTo($this->mockXMLStreamWriter), $this->equalTo($this->mockXMLSerializer));216 $mockXMLGenerator = $this->getMock('stubXMLGenerator'); 217 $this->mockInjector->expects($this->exactly(3))->method('getInstance')->will($this->returnValue($mockXMLGenerator)); 218 $mockXMLGenerator->expects($this->exactly(3))->method('generate')->with($this->equalTo($this->mockXMLStreamWriter), $this->equalTo($this->mockXMLSerializer)); 217 219 $resultXSL = new DOMDocument(); 218 220 $mockSkinGenerator = $this->getMock('stubSkinGenerator');
