Changeset 139

Timestamp:

01/23/07 15:52:21 (2 years ago)

Author:

mikey

Message:

added hasValueErrors($source = self::SOURCE_PARAM)

Files:

• trunk/src/main/php/net/stubbles/ipo/request/stubBaseRequest.php (modified) (1 diff)
• trunk/src/main/php/net/stubbles/ipo/request/stubRequest.php (modified) (1 diff)
• trunk/src/main/php/net/stubbles/ipo/request/stubRequestPrefixDecorator.php (modified) (2 diffs)
• trunk/src/test/php/net/stubbles/ipo/request/stubBaseRequestTestCase.php (modified) (4 diffs)
• trunk/src/test/php/net/stubbles/ipo/request/stubRequestPrefixDecoratorTestCase.php (modified) (3 diffs)

trunk/src/main/php/net/stubbles/ipo/request/stubBaseRequest.php

@@ -154 +154 @@
-    
-    /**
+     * checks whether there are any value errors
+     *
+     * @param   int   $source  optional  source type: cookie, header, param
+     * @return  bool
+     */
+    public function hasValueErrors($source = self::SOURCE_PARAM)
+    {
+        return (count($this->getErrors($source)) > 0);
+    }
+    
+    /**
-     * returns a list of all request value names with their errors
-     *

trunk/src/main/php/net/stubbles/ipo/request/stubRequest.php

@@ -64 +64 @@
-    
-    /**
+     * checks whether there are any value errors
+     *
+     * @param   int   $source  optional  source type: cookie, header, param
+     * @return  bool
+     */
+    public function hasValueErrors($source = self::SOURCE_PARAM);
+    
+    /**
-     * returns a list of all request value names with their errors
-     *

trunk/src/main/php/net/stubbles/ipo/request/stubRequestPrefixDecorator.php

@@ -100 +100 @@
-
-    /**
+     * checks whether there are any value errors
+     *
+     * @param   int   $source  optional  source type: cookie, header, param
+     * @return  bool
+     */
+    public function hasValueErrors($source = self::SOURCE_PARAM)
+    {
+        return (count($this->getValueErrors($source)) > 0);
+    }
+
+    /**
-     * returns a list of all request value names with their errors
-     *
@@ -108 +119 @@
-    {
-        $valueErrors   = $this->request->getValueErrors($source);
-
+ || count($valueErrors) == 0
-            return $valueErrors;
-        }

trunk/src/test/php/net/stubbles/ipo/request/stubBaseRequestTestCase.php

@@ -240 +240 @@
-        $this->assertFalse($this->request->hasValueError('foo'));
-        $this->assertEqual($this->request->getValueError('foo'), array());
+        $this->assertFalse($this->request->hasValueErrors());
-        $this->assertEqual($this->request->getValueErrors('foo'), array());
-        
@@ -254 +255 @@
-        $this->assertTrue($this->request->hasValueError('foo'));
-        $this->assertEqual($this->request->getValueError('foo'), array($errorValue));
+        $this->assertTrue($this->request->hasValueErrors());
-        $this->assertEqual($this->request->getValueErrors('foo'), array('foo' => array($errorValue)));
-        
-        $this->assertTrue($this->request->hasValueError('foo', stubRequest::SOURCE_PARAM));
-        $this->assertEqual($this->request->getValueError('foo', stubRequest::SOURCE_PARAM), array($errorValue));
+        $this->assertTrue($this->request->hasValueErrors(stubRequest::SOURCE_PARAM));
-        $this->assertEqual($this->request->getValueErrors('foo', stubRequest::SOURCE_PARAM), array('foo' => array($errorValue)));
-        
-        $this->assertTrue($this->request->hasValueError('foo', 'dummy'));
-        $this->assertEqual($this->request->getValueError('foo', 'dummy'), array($errorValue));
+        $this->assertTrue($this->request->hasValueErrors('dummy'));
-        $this->assertEqual($this->request->getValueErrors('foo', 'dummy'), array('foo' => array($errorValue)));
-    }
@@ -272 +276 @@
-        $this->assertFalse($this->request->hasValueError('foo', stubRequest::SOURCE_HEADER));
-        $this->assertEqual($this->request->getValueError('foo', stubRequest::SOURCE_HEADER), array());
+        $this->assertFalse($this->request->hasValueErrors(stubRequest::SOURCE_HEADER));
-        $this->assertEqual($this->request->getValueErrors(stubRequest::SOURCE_HEADER), array());
-        
-        $errorValue = new stubRequestValueError('bar', array());
-        $this->request->setHeaderError('foo', $errorValue);
-get
+has
-        $this->assertEqual($this->request->getValueError('foo', stubRequest::SOURCE_HEADER), array($errorValue));
+        $this->assertTrue($this->request->hasValueErrors(stubRequest::SOURCE_HEADER));
-        $this->assertEqual($this->request->getValueErrors(stubRequest::SOURCE_HEADER), array('foo' => array($errorValue)));
-    }
@@ -288 +294 @@
-        $this->assertFalse($this->request->hasValueError('foo', stubRequest::SOURCE_COOKIE));
-        $this->assertEqual($this->request->getValueError('baz', stubRequest::SOURCE_COOKIE), array());
+        $this->assertFalse($this->request->hasValueErrors(stubRequest::SOURCE_COOKIE));
-        $this->assertEqual($this->request->getValueErrors(stubRequest::SOURCE_COOKIE), array());
-        
-        $errorValue = new stubRequestValueError('bar', array());
-        $this->request->setCookieError('foo', $errorValue);
-get
+has
-        $this->assertEqual($this->request->getValueError('foo', stubRequest::SOURCE_COOKIE), array($errorValue));
+        $this->assertTrue($this->request->hasValueErrors(stubRequest::SOURCE_COOKIE));
-        $this->assertEqual($this->request->getValueErrors(stubRequest::SOURCE_COOKIE), array('foo' => array($errorValue)));
-    }

trunk/src/test/php/net/stubbles/ipo/request/stubRequestPrefixDecoratorTestCase.php

@@ -112 +112 @@
-        $this->request->getValueError('foo');
-        
+        $this->mockRequest->expect('hasValueErrors', array(stubRequest::SOURCE_PARAM));
+        $this->request->hasValueErrors();
+        
-        $this->mockRequest->setReturnValue('getValueErrors', array('test_foo' => array(), 'bar' => array()));
-        $this->assertEqual($this->request->getValueErrors(), array('foo' => array()));
@@ -126 +129 @@
-        $this->mockRequest->expect('getValueError', array('foo', stubRequest::SOURCE_HEADER));
-        $this->request->getValueError('foo', stubRequest::SOURCE_HEADER);
+        
+        $this->mockRequest->expect('hasValueErrors', array(stubRequest::SOURCE_HEADER));
+        $this->request->hasValueErrors();
-        
-        $this->mockRequest->expect('getValueErrors', array(stubRequest::SOURCE_HEADER));
@@ -143 +149 @@
-        $this->request->getValueError('foo', stubRequest::SOURCE_COOKIE);
-        
+        $this->mockRequest->expect('hasValueErrors', array(stubRequest::SOURCE_COOKIE));
+        $this->request->hasValueErrors();
+        
-        $this->mockRequest->expect('getValueErrors', array(stubRequest::SOURCE_COOKIE));
-        $this->mockRequest->setReturnValue('getValueErrors', array('test_foo' => array(), 'bar' => array()));